sosour
April 7, 2023, 2:41pm
1
checking, after the recent update MM wont auto switch chain between dapps. Previously if i am in a dapp and use different chain, MM will auto conenct for me. Now i have to manually browse through all the network in MM each time which is a hassle. Is there any fix?
1 Like
@sosour , this will be fixed soon in the next 10.28.2 update
1 Like
sosour
April 7, 2023, 2:53pm
3
cool. Really need the auto switch back. and then all the ‘X’ beside the network and quite jarring to the eye. i just want a clear view of all the network in the list. Either make a UI change or remove it completely as i can just go to add network and remove the chain / rpc.
But good to hear the auto network switch will be back. Driving me crazy and i have search high and low in all the forum thinking its just me.
sosour
April 8, 2023, 5:42am
4
Good day,
Updated MM to 10.28.2. The auto switch chain between dapps is still not working. Pls fix it. URGENT.
sosour
April 9, 2023, 3:19am
5
Good day,
Checking why is it some chain or custom RPC is not able to auto switch? For the latest version, MM is able to switch automically between some default RPC. All the custom RPCs for other chain MM is not able to auto switch. Previous version before 10.28.1m MM is working fine. Please take a look and fix it. We have many custom RPC for other chains and it is a hassle with MM not able to auto link and switch to it.
Hello @sosour , welcome to MetaMask community!
Team is aware of these issues and will fix them as soon as possible. Thank you for reporting it.
2 Likes
fyzxc
April 9, 2023, 3:19pm
7
Upgrading the wallet can’t automatically switch the network, it really broke me down, the network needs dozens of connections, and a manual switch is too troublesome
sosour
April 12, 2023, 8:07am
8
When is the chain switch bug going to be fixed? Not a priority for you all? I have been manually switching for days and about to switch to rabby.
There were still some errors persisting in 10.28.2, but it should all be fixed now in 10.28.3 soon.
See here for more info:
MetaMask:develop ← MetaMask:fix-wallet_switchEthereumNetwork-2
opened 09:48AM - 08 Apr 23 UTC
Fixes https://github.com/MetaMask/metamask-extension/issues/18509
Fixes https:/… /github.com/MetaMask/metamask-extension/issues/18453
## Explanation
We partially fixed the symptom of 18509 and 18453 with https://github.com/MetaMask/metamask-extension/pull/18483, but that fix was incomplete.
This bug will be experienced by anyone who added a network while on v10.27.0 or earlier, and are now on v10.28.1 or v10.28.2 and trying to confirm a dapp prompted switch to that network. This bug will not affect users who first added the network, via a dapp wallet_addEthereumChain request, while on v10.28.1 . This bug also won't affect users who added the network via the MetaMask UI in v10.28.1
The problem is that migration 82 did not add an `id` property to each network configuration object, but we assume that `id` property exists in the `switch-ethereum-chain.js` handler. If a user adds a network on version v10.27.0 or earlier, and then updates to v10.28.x, migration 82 will create an object within `NetworkController.networkConfigurations` keyed by a random id, but that `id` will not be added to that object itself. Later, when we attempt to switch to the network using that objects `id` property, it fails. It does not fail if the network is added while on v10.28.x, because the `upsertNetworkConfiguration` method, which is called when adding a network on v10.28.x, adds an `id` property to each network.
This PR corrects the problem with a migration that ensures that the each key within `networkConfigurations` is used to set the `id` property of the respective object.
### Before
This video shows what would happen when upgrading from v10.27.0 -> v10.28.2 and then trying to switch to a previously added network:
https://user-images.githubusercontent.com/7499938/230714011-86eef63c-b54d-4b79-b51c-1903e1016a27.mp4
### After
This shows switch network working after an upgrade from v10.27.0 to the branch of this PR:
https://user-images.githubusercontent.com/7499938/230714738-16fa8e2e-be3e-4c71-94b3-01220bb618b8.mp4
## Manual Testing Steps
Do as is done in the above "After" video:
1. Build v10.27.0, from d8591d48c, install and onboard
2. Go to https://syncswap.xyz/, connect and add the suggested network
3. In MetaMask, select Ethereum Mainnet, so that the zkSync network is not selected
4. git checkout this branch, build and then reload the metamask installation that was previously built from v10.27.0
5. login to MetaMask and then go to https://syncswap.xyz/
6. click "Connect Wallet" and confirm the switch network popup
7. open MetaMask, you should now have the zksync network selected
## Pre-merge author checklist
- [ ] I've clearly explained:
- [ ] What problem this PR is solving
- [ ] How this problem was solved
- [ ] How reviewers can test my changes
- [ ] Sufficient automated test coverage has been added
## Pre-merge reviewer checklist
- [ ] Manual testing (e.g. pull and build branch, run in browser, test code being changed)
- [ ] PR is linked to the appropriate GitHub issue
- [ ] **IF** this PR fixes a bug in the release milestone, add this PR to the release milestone
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the `Extension QA Board` label.
In this case, a QA Engineer approval will be be required.
Thank you for your understanding!
3 Likes
sosour
April 13, 2023, 3:44pm
10
looks like 10.28.3 is working. so far so good. hope it doesn’t break again!
Thank you.
1 Like
system
May 7, 2023, 2:42pm
11
This topic was automatically closed after 25 days. New replies are no longer allowed.
